lkml.org 
[lkml]   [2020]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter
From
Date
On Fri, 2020-07-03 at 07:56 +0200, Miguel Ojeda wrote:
> On Thu, Jul 2, 2020 at 3:50 PM Christoph Hellwig <hch@lst.de> wrote:
> > Do you have a suggestion for an automated replacement which does?
> > I'll happily switch over to that.
>
> I guess I'd simply find the unique set of cases that occur and create
> a replacement for each manually. A handful of them or so may already
> cover the majority of cases. CC'ing Joe since he deals with this sort
> of stuff all the time.

I do that with a diff and emacs script.

And I'd generally not bother with 80 column rewrapping
here as it both makes a diff harder for not much value and
it's only a few characters added to a few lines that might
now exceed 80 columns.

I presume that clang-format would work well enough too.

\
 
 \ /
  Last update: 2020-07-03 09:44    [W:0.074 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site