Messages in this thread | | | Subject | Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter | From | Joe Perches <> | Date | Fri, 03 Jul 2020 00:44:12 -0700 |
| |
On Fri, 2020-07-03 at 07:56 +0200, Miguel Ojeda wrote: > On Thu, Jul 2, 2020 at 3:50 PM Christoph Hellwig <hch@lst.de> wrote: > > Do you have a suggestion for an automated replacement which does? > > I'll happily switch over to that. > > I guess I'd simply find the unique set of cases that occur and create > a replacement for each manually. A handful of them or so may already > cover the majority of cases. CC'ing Joe since he deals with this sort > of stuff all the time.
I do that with a diff and emacs script.
And I'd generally not bother with 80 column rewrapping here as it both makes a diff harder for not much value and it's only a few characters added to a few lines that might now exceed 80 columns.
I presume that clang-format would work well enough too.
| |