lkml.org 
[lkml]   [2020]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/14] block: lift setting the readahead size into the block layer
On Wed, Jul 22, 2020 at 07:13:54AM +0000, Johannes Thumshirn wrote:
> On 22/07/2020 08:27, Christoph Hellwig wrote:
> > + q->backing_dev_info->ra_pages =
> > + max(queue_io_opt(q) * 2 / PAGE_SIZE, VM_READAHEAD_PAGES);
>
> Dumb question, wouldn't a '>> PAGE_SHIFT' be better instead of a potentially
> costly division?
>
> Or aren't we caring at all as it's a) not in the fast-path and b) compilers
> can optimize it to a shift?

That's my thinking. If anyone has a strong preference I can change
it.

\
 
 \ /
  Last update: 2020-07-22 09:19    [W:0.050 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site