| From | Johannes Thumshirn <> | Subject | Re: [PATCH 06/14] block: lift setting the readahead size into the block layer | Date | Wed, 22 Jul 2020 07:13:54 +0000 |
| |
On 22/07/2020 08:27, Christoph Hellwig wrote: > + q->backing_dev_info->ra_pages = > + max(queue_io_opt(q) * 2 / PAGE_SIZE, VM_READAHEAD_PAGES);
Dumb question, wouldn't a '>> PAGE_SHIFT' be better instead of a potentially costly division?
Or aren't we caring at all as it's a) not in the fast-path and b) compilers can optimize it to a shift?
|