lkml.org 
[lkml]   [2020]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding
Date
Hi Jagan,

Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki:
> Add dt-bindings for ROCKPi 4B which is similar to 4A with
> additional AP6256 Wifi/BT, PoE.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - new patch
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 36057c9e4b83..7250adb43d24 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -448,6 +448,12 @@ properties:
> - const: radxa,rockpi4a
> - const: rockchip,rk3399
>
> + - description: Radxa ROCK Pi 4B
> + items:
> + - const: radxa,rockpi4
> + - const: radxa,rockpi4b
> + - const: rockchip,rk3399
> +

Please do all RockPi4 variants into one entry, so we want something like:

- description: Radxa ROCK Pi 4
items:
- enum:
- radxa,rockpi4a
- radxa,rockpi4b
- radxa,rockpi4c
- const: radxa,rockpi4
- const: rockchip,rk3399

And as the {a,b,c} variant is the most specific it also should be the
first entry, not the second.


Heiko

> - description: Radxa ROCK Pi N8
> items:
> - const: radxa,rockpi-n8
>




\
 
 \ /
  Last update: 2020-07-23 01:15    [W:0.094 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site