lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding
On Thu, Jul 23, 2020 at 12:39:44AM +0530, Jagan Teki wrote:
> ROCKPi 4 has 3 variants of hardware platforms called
> ROCKPi 4A, 4B, and 4C.
>
> - ROCKPi 4A has no Wif/BT.
> - ROCKPi 4B has AP6256 Wifi/BT, PoE.
> - ROCKPi 4C has AP6256 Wifi/BT, PoE, miniDP, USB Host enabled
> GPIO pin change compared to 4B, 4C
>
> So, update the existing ROCKPi 4 with ROCKPi 4A binding.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - new patch
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 41f919de1ad4..36057c9e4b83 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -442,9 +442,10 @@ properties:
> - const: radxa,rock
> - const: rockchip,rk3188
>
> - - description: Radxa ROCK Pi 4
> + - description: Radxa ROCK Pi 4A
> items:
> - const: radxa,rockpi4
> + - const: radxa,rockpi4a
> - const: rockchip,rk3399

That's not what I suggested. And this is just wrong as the order is most
specific to least specific.

This is what I suggest:

items:
- enum:
- radxa,rockpi4 # ROCK Pi 4A
- radxa,rockpi4b
- radxa,rockpi4c
- const: rockchip,rk3399

>
> - description: Radxa ROCK Pi N8
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2020-07-23 22:22    [W:1.469 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site