Messages in this thread | | | Subject | Re: [PATCH for v5.9] i2c: Replace HTTP links with HTTPS ones | From | "Alexander A. Klimov" <> | Date | Tue, 21 Jul 2020 19:56:36 +0200 |
| |
Am 21.07.20 um 11:50 schrieb Jean Delvare: > Hi Alexander, > > On Sun, 19 Jul 2020 21:35:53 +0200, Alexander A. Klimov wrote: >> Rationale: >> Reduces attack surface on kernel devs opening the links for MITM >> as HTTPS traffic is much harder to manipulate. >> (...) >> Documentation/i2c/busses/i2c-ali1535.rst | 2 +- >> Documentation/i2c/busses/i2c-ali15x3.rst | 2 +- >> Documentation/i2c/busses/i2c-piix4.rst | 4 ++-- >> drivers/i2c/busses/i2c-ali1535.c | 2 +- >> drivers/i2c/busses/i2c-ali15x3.c | 2 +- >> 5 files changed, 6 insertions(+), 6 deletions(-) > > The diffstat above does not match the changes below (specifically > i2c-piix4.rst is NOT modified by your actual patch). Yes, I've chosen "the easy way" of git commit --amend: Editing the patch file. I this a problem?
> >> diff --git a/Documentation/i2c/busses/i2c-ali1535.rst b/Documentation/i2c/busses/i2c-ali1535.rst >> index 6941064730dc..3fe2bad63597 100644 >> --- a/Documentation/i2c/busses/i2c-ali1535.rst >> +++ b/Documentation/i2c/busses/i2c-ali1535.rst >> @@ -28,7 +28,7 @@ Additionally, the sequencing of the SMBus transactions has been modified to >> be more consistent with the sequencing recommended by the manufacturer and >> observed through testing. These changes are reflected in this driver and >> can be identified by comparing this driver to the i2c-ali15x3 driver. For >> -an overview of these chips see http://www.acerlabs.com >> +an overview of these chips see https://www.acerlabs.com >> (...) > > A quick visit to this website shows that it is dead and useless. The > closest thing nowadays would be https://www.ali.com.tw/ however as far > as I know ALI sold their x86 chipset business to Nvidia in 2006. I > couldn't find information about these old chipsets on either website > though, so I believe that the best course of action would be to strip > the links and surrounding sentences. I don't agree with you. IMAO broken links should be archive.org-ed. I've added that to my todo list.
> > I understand this is beyond the scope of your current project. Do you > want me to take care of that? >
| |