Messages in this thread Patch in this message | | | From | Wolfram Sang <> | Subject | [PATCH v2] firmware: improve description of firmware_request_nowarn | Date | Fri, 3 Jul 2020 00:11:07 +0200 |
| |
The doubled 'however' is confusing. Simplify the comment a little and reformat the paragraph.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Luis Chamberlain <mcgrof@kernel.org> ---
Changes since v1: * removed uneeded empty line (sorry!) * added Luis' ack
drivers/base/firmware_loader/main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index ca871b13524e..9da0c9d5f538 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -838,12 +838,12 @@ EXPORT_SYMBOL(request_firmware); * @name: name of firmware file * @device: device for which firmware is being loaded * - * This function is similar in behaviour to request_firmware(), except - * it doesn't produce warning messages when the file is not found. - * The sysfs fallback mechanism is enabled if direct filesystem lookup fails, - * however, however failures to find the firmware file with it are still - * suppressed. It is therefore up to the driver to check for the return value - * of this call and to decide when to inform the users of errors. + * This function is similar in behaviour to request_firmware(), except it + * doesn't produce warning messages when the file is not found. The sysfs + * fallback mechanism is enabled if direct filesystem lookup fails. However, + * failures to find the firmware file with it are still suppressed. It is + * therefore up to the driver to check for the return value of this call and to + * decide when to inform the users of errors. **/ int firmware_request_nowarn(const struct firmware **firmware, const char *name, struct device *device) -- 2.27.0
| |