lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 16/30] scsi: arcmsr: arcmsr_hba: Make room for the trailing NULL, even if it is over-written
On Wed, 15 Jul 2020, Martin K. Petersen wrote:

>
> Lee,
>
> > Ensure we do not copy the final one (which is not overwitten).
> >
> > - strncpy(&inqdata[8], "Areca ", 8);
> > + strncpy(&inqdata[8], "Areca ", 9);
> > /* Vendor Identification */
> > - strncpy(&inqdata[16], "RAID controller ", 16);
> > + strncpy(&inqdata[16], "RAID controller ", 17);
> > /* Product Identification */
> > - strncpy(&inqdata[32], "R001", 4); /* Product Revision */
> > + strncpy(&inqdata[32], "R001", 5); /* Product Revision */
>
> SCSI INQUIRY strings are fixed length and not NULL-terminated. Please
> address this warning using either memcpy() or strlcpy().

Will do. Thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2020-07-16 10:00    [W:0.137 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site