Messages in this thread | | | Subject | Re: [PATCH 16/30] scsi: arcmsr: arcmsr_hba: Make room for the trailing NULL, even if it is over-written | From | "Martin K. Petersen" <> | Date | Wed, 15 Jul 2020 16:26:33 -0400 |
| |
Lee,
> Ensure we do not copy the final one (which is not overwitten). > > - strncpy(&inqdata[8], "Areca ", 8); > + strncpy(&inqdata[8], "Areca ", 9); > /* Vendor Identification */ > - strncpy(&inqdata[16], "RAID controller ", 16); > + strncpy(&inqdata[16], "RAID controller ", 17); > /* Product Identification */ > - strncpy(&inqdata[32], "R001", 4); /* Product Revision */ > + strncpy(&inqdata[32], "R001", 5); /* Product Revision */
SCSI INQUIRY strings are fixed length and not NULL-terminated. Please address this warning using either memcpy() or strlcpy().
Thanks!
-- Martin K. Petersen Oracle Linux Engineering
| |