Messages in this thread |  | | Date | Wed, 15 Jul 2020 23:41:34 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 00/18] perf metric: Add support to reuse metric |
| |
On Wed, Jul 15, 2020 at 01:33:27PM -0500, Paul A. Clarke wrote: > On Sun, Jul 12, 2020 at 03:26:16PM +0200, Jiri Olsa wrote: > > hi, > > this patchset is adding the support to reused metric in another > > metric. The metric needs to be referenced by 'metric:' prefix. > > > > For example, to define IPC by using CPI with change like: > > > > "BriefDescription": "Instructions Per Cycle (per Logical Processor)", > > - "MetricExpr": "INST_RETIRED.ANY / CPU_CLK_UNHALTED.THREAD", > > + "MetricExpr": "1/metric:CPI", > > "MetricGroup": "TopDownL1", > > "MetricName": "IPC" > > > > I won't be able to find all the possible places we could > > use this at, so I wonder you guys (who was asking for this) > > would try it and come up with comments if there's something > > missing or we could already use it at some places. > > > > It's based on Arnaldo's tmp.perf/core. > > > > v2 changes: > > - collected Ian's acks for few patches [Ian] > > - renamed expr__add_id to expr__add_id_val [Ian] > > - renamed expr_parse_data to expr_id_data [Ian] > > - added recursion check [Ian] > > - added metric test for DCache_L2 metric [Ian] > > - added some renames as discussed in review [Ian] > > > > Also available in here: > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > > perf/metric > > I'm having trouble testing this. > > I checked out this tree, and am able to build with a JSON metrics definition > file which uses other metrics. I put this aside, though, because of the > following issue. > > I built the kernel from this same tree and booted it successfully. > However, the metrics are not working correctly. (I may very well be > doing something wrong.)
if you'll share the metric change I can help debugging that
> > The base system is RHEL8, but it's now booted with the new kernel. > ``` > # uname -a > Linux system 5.8.0-rc4-g7dd02cf0b #1 SMP Wed Jul 15 12:31:45 EDT 2020 ppc64le ppc64le ppc64le GNU/Linux > # perf stat --metrics cpi_breakdown ./load > failed: way too many variables
hm, this ^^^ error string was removed in: 43fe337c86a9 perf expr: Migrate expr ids table to a hashmap
looks like you're not running the correct perf binary
thanks for testing this, jirka
|  |