Messages in this thread | | | Date | Wed, 1 Jul 2020 19:06:43 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning |
| |
On 01-07-20, 16:19, Laurent Pinchart wrote: > Hi Tobias, > > Thank you for the patch. > > On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias Klauser wrote: > > This fixes the following compiler warning when building with > > CONFIG_PM && !CONFIG_PM_SLEEP: > > > > drivers/phy/xilinx/phy-zynqmp.c:830:12: warning: ‘xpsgtr_resume’ defined but not used [-Wunused-function] > > 830 | static int xpsgtr_resume(struct device *dev) > > | ^~~~~~~~~~~~~ > > drivers/phy/xilinx/phy-zynqmp.c:819:12: warning: ‘xpsgtr_suspend’ defined but not used [-Wunused-function] > > 819 | static int xpsgtr_suspend(struct device *dev) > > | ^~~~~~~~~~~~~~ > > Oops :-S Sorry about that. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Vinod or Kishon, can you pick this patch up, or do I need to send a pull > request ? (It's my first driver in the PHY subsystem so I don't know > what the usual practices are there)
patches are welcome :-)
> > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > > --- > > drivers/phy/xilinx/phy-zynqmp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c > > index 8babee2ce9ec..22a0ae635797 100644 > > --- a/drivers/phy/xilinx/phy-zynqmp.c > > +++ b/drivers/phy/xilinx/phy-zynqmp.c > > @@ -815,7 +815,7 @@ static struct phy *xpsgtr_xlate(struct device *dev, > > * Power Management > > */ > > > > -#ifdef CONFIG_PM > > +#ifdef CONFIG_PM_SLEEP
How about marking it as __maybe_unused instead?
-- ~Vinod
| |