Messages in this thread | | | Date | Wed, 1 Jul 2020 19:25:43 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning |
| |
Hi Laurent,
On 01-07-20, 16:44, Laurent Pinchart wrote:
> > How about marking it as __maybe_unused instead? > > I don't mind either, I'll let Tobias decide, but his patch seems fine, > is there a drawback in his approach ? If it's just a matter of personal > preference, I'd rather not require a v2.
__maybe_unused is the preferred way to do as Documented in Documentation/process/coding-style.rst and makes code look neater..
Thanks -- ~Vinod
| |