| From | Andy Shevchenko <> | Date | Fri, 5 Jun 2020 15:06:35 +0300 | Subject | Re: [PATCH v4 07/11] hwmon: add support for the sl28cpld hardware monitoring controller |
| |
On Fri, Jun 5, 2020 at 12:14 AM Michael Walle <michael@walle.cc> wrote: > > Add support for the hardware monitoring controller of the sl28cpld board > management controller. This driver is part of a multi-function device.
...
> +#include <linux/of_device.h>
mod_devicetable.h ?
...
> + hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev, > + "sl28cpld_hwmon", hwmon, > + &sl28cpld_hwmon_chip_info, NULL); > + if (IS_ERR(hwmon_dev)) { > + dev_err(&pdev->dev, "failed to register as hwmon device");
> + return PTR_ERR(hwmon_dev); > + } > + > + return 0;
PTR_ERR_OR_ZERO() ?
...
> +static const struct of_device_id sl28cpld_hwmon_of_match[] = { > + { .compatible = "kontron,sl28cpld-fan" },
> + {},
No comma.
> +};
-- With Best Regards, Andy Shevchenko
|