Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 5 Jun 2020 13:50:43 +0300 | Subject | Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog |
| |
On Fri, Jun 5, 2020 at 1:24 PM Michael Walle <michael@walle.cc> wrote: > Am 2020-06-05 10:14, schrieb Andy Shevchenko: > > On Fri, Jun 5, 2020 at 12:14 AM Michael Walle <michael@walle.cc> wrote:
...
> >> +static bool nowayout = WATCHDOG_NOWAYOUT; > >> +module_param(nowayout, bool, 0); > >> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started > >> (default=" > >> + __MODULE_STRING(WATCHDOG_NOWAYOUT) > >> ")"); > >> + > >> +static int timeout; > >> +module_param(timeout, int, 0); > >> +MODULE_PARM_DESC(timeout, "Initial watchdog timeout in seconds"); > > > > Guenter ACKed this, but I'm wondering why we still need module > > parameters... > > How would a user change the nowayout or the timeout? For the latter > there is > a device tree entry, but thats not easy changable by the user.
Yes, it's more question to VIm and Guenter than to you.
...
> >> + if (status & WDT_CTRL_EN) { > >> + sl28cpld_wdt_start(wdd); > > > >> + set_bit(WDOG_HW_RUNNING, &wdd->status); > > > > Do you need atomic op here? Why? > > I'd say consistency, all watchdog drivers do it like that. I just > had a look at where this is used, but it looks like access from > userspace is protected by a lock.
Okay then.
-- With Best Regards, Andy Shevchenko
| |