Messages in this thread | | | Date | Fri, 19 Jun 2020 08:29:13 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC |
| |
Hello again,
On Fri, Jun 19, 2020 at 08:02:13AM +0200, Uwe Kleine-König wrote: > You had concerns about my review feedback that I don't like the fan > stuff in the PWM driver. I still think that the fan part doesn't belong > here.
I suggest splitting the patch. First introduce a generic PWM driver and in a second patch add the fan stuff. This way you can get an ack from me at least for a part. Also it makes it more obvious that there is going on something special and we can have a dedicated discussion about it and a concious decision made at the end.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |