lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] Input: bma150: fix ref count leak in bma150_open
From
Date
> in bma150_open, …

* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?

* Would you like to add the tag “Fixes”?



> +++ b/drivers/input/misc/bma150.c

> @@ -357,10 +357,13 @@ static int bma150_open(struct input_dev *input)
> if (bma150->mode != BMA150_MODE_NORMAL) {
> error = bma150_set_mode(bma150, BMA150_MODE_NORMAL);
> if (error)
> - return error;
> + goto out;
> }
>
> return 0;
> +out:
> + pm_runtime_put_noidle(&bma150->client->dev);
> + return error;
> }


Perhaps use the label “put_runtime” instead?

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-15 18:19    [W:0.055 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site