Messages in this thread | | | Subject | Re: [PATCH v2] drm/etnaviv: fix ref count leak via pm_runtime_get_sync | From | Markus Elfring <> | Date | Mon, 15 Jun 2020 17:57:38 +0200 |
| |
… > In case of failure, decrement the ref count before returning.
Can it be nicer to use the term “reference count” here?
Will the tag “Fixes” become helpful for the commit message?
… > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c … > @@ -1326,6 +1331,7 @@ struct dma_fence *etnaviv_gpu_submit(struct etnaviv_gem_submit *submit) > ret = event_alloc(gpu, nr_events, event); > if (ret) { > DRM_ERROR("no free events\n"); > + pm_runtime_put_noidle(gpu->dev); > return NULL; > }
I suggest to move a bit of exception handling code to the end of this function implementation so that it can be better reused after the addition of a jump target like “put_runtime”.
Regards, Markus
| |