lkml.org 
[lkml]   [2020]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] coresight: cti: Fix error handling in probe
On Fri, Jun 12, 2020 at 02:11:16PM +0000, Walter Harms wrote:
> Hi Dan,
>
> nit picking in cti_pm_release()
>
> IMHO this should be done in 2 steps:
> if (--nr_cti_cpu == 0)
> ->
> --nr_cti_cpu ;
> if ( nr_cti_cpu == 0)

The first way is sort of the more canonical way to write it... By far.

regards,
carpenter

\
 
 \ /
  Last update: 2020-06-12 19:44    [W:3.751 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site