Messages in this thread | | | From | Pavel Tatashin <> | Date | Thu, 7 May 2020 08:57:50 -0400 | Subject | Re: [PATCH v3 3/6] pstore/ram: Refactor DT size parsing |
| |
On Wed, May 6, 2020 at 5:15 PM Kees Cook <keescook@chromium.org> wrote: > > Refactor device tree size parsing routines to be able to pass a non-zero > default value for providing a configurable default for the coming > "max_reason" field. > > Signed-off-by: Kees Cook <keescook@chromium.org>
ramoops_parse_dt_size parse_size
Are used to parse flags, and max-reason properties, so the "size" in their names become outdated. How about: ramoops_parse_dt_prop parse_prop
Otherwise it looks good.
Thank you, Pasha
| |