Messages in this thread | | | Date | Thu, 7 May 2020 11:04:32 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3 3/6] pstore/ram: Refactor DT size parsing |
| |
On Thu, May 07, 2020 at 08:57:50AM -0400, Pavel Tatashin wrote: > On Wed, May 6, 2020 at 5:15 PM Kees Cook <keescook@chromium.org> wrote: > > > > Refactor device tree size parsing routines to be able to pass a non-zero > > default value for providing a configurable default for the coming > > "max_reason" field. > > > > Signed-off-by: Kees Cook <keescook@chromium.org> > > ramoops_parse_dt_size > parse_size > > Are used to parse flags, and max-reason properties, so the "size" in > their names become outdated. How about: > ramoops_parse_dt_prop > parse_prop
Yeah, I struggled with that thought too.
> Otherwise it looks good.
Okay, great, I'll find a better name and apply this series. Thanks!
-- Kees Cook
| |