lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 01/10] pstore: Drop useless try_module_get() for backend
Date
There is no reason to be doing a module get/put in pstore_register(),
since the module calling pstore_register() cannot be unloaded since it
hasn't finished its initialization. Remove it so there is no confusion
about how registration ordering works.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/platform.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 408277ee3cdb..44f8b9742263 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -555,8 +555,6 @@ static int pstore_write_user_compat(struct pstore_record *record,
*/
int pstore_register(struct pstore_info *psi)
{
- struct module *owner = psi->owner;
-
if (backend && strcmp(backend, psi->name)) {
pr_warn("ignoring unexpected backend '%s'\n", psi->name);
return -EPERM;
@@ -591,10 +589,6 @@ int pstore_register(struct pstore_info *psi)
sema_init(&psinfo->buf_lock, 1);
spin_unlock(&pstore_lock);

- if (owner && !try_module_get(owner)) {
- psinfo = NULL;
- return -EINVAL;
- }

if (psi->flags & PSTORE_FLAGS_DMESG)
allocate_buf_for_compression();
@@ -626,8 +620,6 @@ int pstore_register(struct pstore_info *psi)

pr_info("Registered %s as persistent store backend\n", psi->name);

- module_put(owner);
-
return 0;
}
EXPORT_SYMBOL_GPL(pstore_register);
--
2.20.1
\
 
 \ /
  Last update: 2020-05-06 17:22    [W:0.050 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site