Messages in this thread | | | Date | Mon, 1 Jun 2020 10:14:56 +1000 (AEST) | From | Finn Thain <> | Subject | Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling |
| |
On Sun, 31 May 2020, Geert Uytterhoeven wrote:
> Hi Finn, > > On Sun, May 31, 2020 at 1:20 AM Finn Thain <fthain@telegraphics.com.au> wrote: > > The adb_driver.autopoll method is needed during ADB bus scan and device > > address assignment. Implement this method so that the IOP's list of > > device addresses can be updated. When the list is empty, disable SRQ > > autopolling. > > > > Cc: Joshua Thompson <funaho@jurai.org> > > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > > Tested-by: Stan Johnson <userm57@yahoo.com> > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > > Thanks for your patch! > > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> >
Thanks for your tag.
> > arch/m68k/include/asm/adb_iop.h | 1 + > > drivers/macintosh/adb-iop.c | 32 ++++++++++++++++++++++++++------ > > As this header file is used by a single source file only, perhaps it > should just be absorbed by the latter?
Sure, it could be absorbed by both asm/mac_iop.h and drivers/macintosh/adb-iop.c but I don't see the point...
> Then you no longer need my Acked-by for future changes ;-) >
But you shouldn't need to ack this kind of change in the first place.
IMHO, the arch/m68k/mac maintainer should be the one to ack changes to both arch/m68k/include/asm/adb_iop.h and drivers/macintosh/adb-iop.c.
Not that I'm complaining (thanks again for your ack!)
| |