Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 1 Jun 2020 11:12:52 +0200 | Subject | Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling |
| |
Hi Finn,
On Mon, Jun 1, 2020 at 2:15 AM Finn Thain <fthain@telegraphics.com.au> wrote: > On Sun, 31 May 2020, Geert Uytterhoeven wrote: > > On Sun, May 31, 2020 at 1:20 AM Finn Thain <fthain@telegraphics.com.au> wrote: > > > arch/m68k/include/asm/adb_iop.h | 1 + > > > drivers/macintosh/adb-iop.c | 32 ++++++++++++++++++++++++++------ > > > > As this header file is used by a single source file only, perhaps it > > should just be absorbed by the latter? > > Sure, it could be absorbed by both asm/mac_iop.h and > drivers/macintosh/adb-iop.c but I don't see the point...
asm/mac_iop.h doesn't include asm/adb_iop.h (at least not in my tree, but perhaps you have plans to change that?), so there's only a single user.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |