Messages in this thread | | | Date | Fri, 29 May 2020 15:08:16 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v2] usb/phy-generic: Add support for OTG VBUS supply control |
| |
On Fri, May 29, 2020 at 08:00:45AM +0200, Mike Looijmans wrote: > This enables support for VBUS on boards where the power is supplied > by a regulator. The regulator is enabled when the USB port enters > HOST mode. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > v2: Added missing "return 0;" in set_vbus method > > .../devicetree/bindings/usb/usb-nop-xceiv.txt | 3 ++ > drivers/usb/phy/phy-generic.c | 46 ++++++++++++++++++- > drivers/usb/phy/phy-generic.h | 2 + > 3 files changed, 50 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt > index 4dc6a8ee3071..775a19fdb613 100644 > --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt > +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt > @@ -16,6 +16,9 @@ Optional properties: > > - vcc-supply: phandle to the regulator that provides power to the PHY. > > +- vbus-supply: phandle to the regulator that provides the VBUS power for when > + the device is in HOST mode. > +
I'm going to say no to expanding this binding...
First, there sure are a lot of controls on a NOP tranceiver.
Second, unless Vbus is supplying the PHY, then this belongs in a connector node for which this is already supported.
> - reset-gpios: Should specify the GPIO for reset. > > - vbus-detect-gpio: should specify the GPIO detecting a VBus insertion
| |