Messages in this thread | | | Subject | Re: [PATCH] PCI: qcom: Improve exception handling in qcom_pcie_probe() | From | Markus Elfring <> | Date | Tue, 26 May 2020 16:30:34 +0200 |
| |
Please avoid a typo in the patch subject (by a possible alternative?).
> In function qcom_pcie_probe(), there are several error-handling problem.
Wording adjustments: This function contained improvable implementation details according to exception handling.
> because refcount will be increased even pm_runtime_get_sync() returns > an error.
because the reference count will be increased despite of the failure. Thus add the missed function call.
> 2. pm_runtime_disable() are called twice, … … Thus remove redundant function calls.
Regards, Markus
| |