lkml.org 
[lkml]   [2020]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] ASoC: mmp-sspa: Fix return value check in asoc_mmp_sspa_probe()
Date
In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
sound/soc/pxa/mmp-sspa.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c
index 3e37ab625f8d..4255851c71c1 100644
--- a/sound/soc/pxa/mmp-sspa.c
+++ b/sound/soc/pxa/mmp-sspa.c
@@ -493,13 +493,13 @@ static int asoc_mmp_sspa_probe(struct platform_device *pdev)
return -ENODEV;

sspa->rx_base = devm_ioremap(&pdev->dev, res->start, 0x30);
- if (IS_ERR(sspa->rx_base))
- return PTR_ERR(sspa->rx_base);
+ if (!sspa->rx_base)
+ return -ENOMEM;

sspa->tx_base = devm_ioremap(&pdev->dev,
res->start + 0x80, 0x30);
- if (IS_ERR(sspa->tx_base))
- return PTR_ERR(sspa->tx_base);
+ if (!sspa->tx_base)
+ return -ENOMEM;

sspa->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(sspa->clk))




\
 
 \ /
  Last update: 2020-05-27 04:57    [W:0.039 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site