lkml.org 
[lkml]   [2020]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI
On Mon, May 18, 2020 at 01:03:59PM -0700, Bhaumik Bhatt wrote:
> +void mhi_create_debugfs(struct mhi_controller *mhi_cntrl)
> +{
> + if (IS_ERR_OR_NULL(mhi_debugfs_root))
> + return;

Why? Should not matter.

> + mhi_cntrl->debugfs_dentry =
> + debugfs_create_dir(dev_name(mhi_cntrl->cntrl_dev),
> + mhi_debugfs_root);
> + if (IS_ERR_OR_NULL(mhi_cntrl->debugfs_dentry))
> + return;

No need for this check either, just call debugfs and keep on moving :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-05-25 08:36    [W:1.316 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site