Messages in this thread | | | Date | Mon, 25 May 2020 08:35:13 +0200 | From | Greg KH <> | Subject | Re: [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI |
| |
On Mon, May 18, 2020 at 01:03:59PM -0700, Bhaumik Bhatt wrote: > +void mhi_create_debugfs(struct mhi_controller *mhi_cntrl) > +{ > + if (IS_ERR_OR_NULL(mhi_debugfs_root)) > + return;
Why? Should not matter.
> + mhi_cntrl->debugfs_dentry = > + debugfs_create_dir(dev_name(mhi_cntrl->cntrl_dev), > + mhi_debugfs_root); > + if (IS_ERR_OR_NULL(mhi_cntrl->debugfs_dentry)) > + return;
No need for this check either, just call debugfs and keep on moving :)
thanks,
greg k-h
| |