Messages in this thread | | | Date | Thu, 21 May 2020 12:33:46 -0700 | From | bbhatt@codeauro ... | Subject | Re: [PATCH v3 0/7] Introduce features and debugfs/sysfs entries for MHI |
| |
On 2020-05-21 06:23, Manivannan Sadhasivam wrote: > Hi, > > On Mon, May 18, 2020 at 01:03:54PM -0700, Bhaumik Bhatt wrote: >> Introduce independent bus and device voting mechanism for clients and >> save >> hardware information from BHI. >> Allow reading and modifying some MHI variables for debug, test, and >> informational purposes using debugfs. >> Read values for device specific hardware information to be used by >> OEMs in >> factory testing such as serial number and PK hash using sysfs. >> > > I think this series is not yet ready. So will not merge any patches in > this > series for 5.8. > > Or let me know if there are any independent patches which should get > merged. > I'm planning to send the final 5.8 series to Greg by Friday. > > Thanks, > Mani > >> This set of patches was tested on arm64 and x86. >> >> v3: >> -Add patch to check for pending packets in suspend as a dependency for >> the >> independent voting mechanism introduction >> -Include register dump entry for debugfs to dump MHI, BHI, and BHIe >> registers >> -Update commit message for the debugfs patch >> -Updated Documentation/ABI with the required info for sysfs >> -Updated debugfs patch to include a new KConfig entry and dependencies >> -Updated reviewed-by for some patches >> >> v2: >> -Added a new debugfs.c file for specific debugfs entries and code >> -Updated commit text and addressed some comments for voting change >> -Made sure sysfs is only used for serial number and OEM PK hash usage >> >> Bhaumik Bhatt (7): >> bus: mhi: core: Abort suspends due to outgoing pending packets >> bus: mhi: core: Introduce independent voting mechanism >> bus: mhi: core: Use generic name field for an MHI device >> bus: mhi: core: Introduce helper function to check device state >> bus: mhi: core: Introduce debugfs entries and counters for MHI >> bus: mhi: core: Read and save device hardware information from BHI >> bus: mhi: core: Introduce sysfs entries for MHI >> >> Documentation/ABI/stable/sysfs-bus-mhi | 25 ++ >> MAINTAINERS | 1 + >> drivers/bus/mhi/Kconfig | 8 + >> drivers/bus/mhi/core/Makefile | 5 +- >> drivers/bus/mhi/core/boot.c | 17 +- >> drivers/bus/mhi/core/debugfs.c | 501 >> +++++++++++++++++++++++++++++++++ >> drivers/bus/mhi/core/init.c | 80 +++++- >> drivers/bus/mhi/core/internal.h | 29 ++ >> drivers/bus/mhi/core/main.c | 6 +- >> drivers/bus/mhi/core/pm.c | 79 ++++-- >> include/linux/mhi.h | 39 ++- >> 11 files changed, 745 insertions(+), 45 deletions(-) >> create mode 100644 Documentation/ABI/stable/sysfs-bus-mhi >> create mode 100644 drivers/bus/mhi/core/debugfs.c >> >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project Hi Mani,
These are patches already reviewed, small and important and good to go:
bus: mhi: core: Abort suspends due to outgoing pending packets bus: mhi: core: Use generic name field for an MHI device bus: mhi: core: Introduce helper function to check device state bus: mhi: core: Read and save device hardware information from BHI
Please let us know if you have any concerns.
Thanks, Bhaumik
| |