Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH][next] drm/i915: fix incorrect return of an error status | Date | Mon, 18 May 2020 18:09:10 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
Currently when a call to intel_atomic_get_dbuf_state fails the error value being returns is a potentially uninitialized value in variable ret. Fix this by returning the error value of new_dbuf_state.
Addresses-Coverity: ("Uninitialized scalar value") Fixes: 3cf43cdc63fb ("drm/i915: Introduce proper dbuf state") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index a21e36ed1a77..762a5184fc69 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -5917,7 +5917,7 @@ skl_ddb_add_affected_pipes(struct intel_atomic_state *state) new_dbuf_state = intel_atomic_get_dbuf_state(state); if (IS_ERR(new_dbuf_state)) - return ret; + return PTR_ERR(new_dbuf_state); old_dbuf_state = intel_atomic_get_old_dbuf_state(state); -- 2.25.1
| |