lkml.org 
[lkml]   [2020]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio
From
Date
Friendly ping...

On 2020/3/30 16:44, Christian Brauner wrote:
> On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote:
>>
>> In kill_pid_usb_asyncio, if signal is not valid, we do not need to
>> set info struct.
>>
>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> I'd have done:
>
> if (!valid_signal(sig))
> return -EINVAL;
>
> instead of setting ret to EINVAL above but that's mostly a matter of style.
>
> Picking this up unless someone sees a problem with it.
>
> Thank you!
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
>
> .
>

\
 
 \ /
  Last update: 2020-04-09 05:27    [W:0.054 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site