lkml.org 
[lkml]   [2020]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio
On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote:
>
> In kill_pid_usb_asyncio, if signal is not valid, we do not need to
> set info struct.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>

I'd have done:

if (!valid_signal(sig))
return -EINVAL;

instead of setting ret to EINVAL above but that's mostly a matter of style.

Picking this up unless someone sees a problem with it.

Thank you!
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

\
 
 \ /
  Last update: 2020-03-30 10:44    [W:0.081 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site