Messages in this thread | | | Date | Mon, 30 Mar 2020 10:44:15 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio |
| |
On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote: > > In kill_pid_usb_asyncio, if signal is not valid, we do not need to > set info struct. > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
I'd have done:
if (!valid_signal(sig)) return -EINVAL;
instead of setting ret to EINVAL above but that's mostly a matter of style.
Picking this up unless someone sees a problem with it.
Thank you! Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
| |