Messages in this thread | | | From | Amit Kucheria <> | Date | Sat, 4 Apr 2020 13:00:00 +0530 | Subject | Re: [PATCH V2 6/9] thermal: Move get_thermal_instance to the internal header |
| |
On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > The function is not used any place other than the thermal > directory. It does not make sense to export its definition in the > global header as there is no use of it. > > Move the definition to the internal header and allow better > self-encapsulation. > > Take the opportunity to add the parameter names to make checkpatch > happy and remove the pointless stubs. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> --- > drivers/thermal/thermal_core.h | 5 +++++ > include/linux/thermal.h | 6 ------ > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h > index 5fb2bd9c7034..c95689586e19 100644 > --- a/drivers/thermal/thermal_core.h > +++ b/drivers/thermal/thermal_core.h > @@ -74,6 +74,11 @@ struct thermal_trip { > > int get_tz_trend(struct thermal_zone_device *tz, int trip); > > +struct thermal_instance * > +get_thermal_instance(struct thermal_zone_device *tz, > + struct thermal_cooling_device *cdev, > + int trip); > + > /* > * This structure is used to describe the behavior of > * a certain cooling device on a certain trip point > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index 8006ba5de855..47e745c5dfca 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -414,8 +414,6 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp); > int thermal_zone_get_slope(struct thermal_zone_device *tz); > int thermal_zone_get_offset(struct thermal_zone_device *tz); > > -struct thermal_instance *get_thermal_instance(struct thermal_zone_device *, > - struct thermal_cooling_device *, int); > void thermal_cdev_update(struct thermal_cooling_device *); > void thermal_notify_framework(struct thermal_zone_device *, int); > #else > @@ -473,10 +471,6 @@ static inline int thermal_zone_get_offset( > struct thermal_zone_device *tz) > { return -ENODEV; } > > -static inline struct thermal_instance * > -get_thermal_instance(struct thermal_zone_device *tz, > - struct thermal_cooling_device *cdev, int trip) > -{ return ERR_PTR(-ENODEV); } > static inline void thermal_cdev_update(struct thermal_cooling_device *cdev) > { } > static inline void thermal_notify_framework(struct thermal_zone_device *tz, > -- > 2.17.1 >
| |