Messages in this thread | | | From | Amit Kucheria <> | Date | Sat, 4 Apr 2020 13:00:00 +0530 | Subject | Re: [PATCH V2 4/9] thermal: Move trip point structure definition to private header |
| |
On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > The struct thermal_trip is only used by the thermal internals, it is > pointless to export the definition in the global header. > > Move the structure to the thermal_core.h internal header. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> --- > drivers/thermal/thermal_core.h | 13 +++++++++++++ > include/linux/thermal.h | 15 --------------- > 2 files changed, 13 insertions(+), 15 deletions(-) > > diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h > index f99551ce9838..d37de708c28a 100644 > --- a/drivers/thermal/thermal_core.h > +++ b/drivers/thermal/thermal_core.h > @@ -58,6 +58,19 @@ int power_actor_get_min_power(struct thermal_cooling_device *cdev, > struct thermal_zone_device *tz, u32 *min_power); > int power_actor_set_power(struct thermal_cooling_device *cdev, > struct thermal_instance *ti, u32 power); > +/** > + * struct thermal_trip - representation of a point in temperature domain > + * @np: pointer to struct device_node that this trip point was created from > + * @temperature: temperature value in miliCelsius > + * @hysteresis: relative hysteresis in miliCelsius > + * @type: trip point type > + */ > +struct thermal_trip { > + struct device_node *np; > + int temperature; > + int hysteresis; > + enum thermal_trip_type type; > +}; > > /* > * This structure is used to describe the behavior of > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index e0279f7b43f4..7adbfe092281 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -332,21 +332,6 @@ struct thermal_zone_of_device_ops { > int (*set_trip_temp)(void *, int, int); > }; > > -/** > - * struct thermal_trip - representation of a point in temperature domain > - * @np: pointer to struct device_node that this trip point was created from > - * @temperature: temperature value in miliCelsius > - * @hysteresis: relative hysteresis in miliCelsius > - * @type: trip point type > - */ > - > -struct thermal_trip { > - struct device_node *np; > - int temperature; > - int hysteresis; > - enum thermal_trip_type type; > -}; > - > /* Function declarations */ > #ifdef CONFIG_THERMAL_OF > int thermal_zone_of_get_sensor_id(struct device_node *tz_np, > -- > 2.17.1 >
| |