Messages in this thread | | | Subject | Re: [PATCH] drm/vboxvideo: Fix a NULL vs IS_ERR() check in vbox_hw_init() | From | Markus Elfring <> | Date | Thu, 30 Apr 2020 11:30:38 +0200 |
| |
> The devm_gen_pool_create() function returns ERR_PTR() on error, it > doesn't return NULL so this check doesn't work.
How do you think about a wording variant like the following?
Change description: A null pointer check was performed after a call of the function “devm_gen_pool_create” despite of the detail that failures are indicated by error pointers instead. Thus adjust a check for the failure predicate and return the corresponding error code.
Regards, Markus
| |