lkml.org 
[lkml]   [2020]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/vboxvideo: Fix a NULL vs IS_ERR() check in vbox_hw_init()
From
Date
> The devm_gen_pool_create() function returns ERR_PTR() on error, it
> doesn't return NULL so this check doesn't work.

How do you think about a wording variant like the following?

Change description:
A null pointer check was performed after a call of the
function “devm_gen_pool_create” despite of the detail
that failures are indicated by error pointers instead.
Thus adjust a check for the failure predicate
and return the corresponding error code.


Regards,
Markus

\
 
 \ /
  Last update: 2020-04-30 11:32    [W:0.085 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site