Messages in this thread | | | Subject | Re: [PATCH] crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe() | From | Markus Elfring <> | Date | Fri, 3 Apr 2020 10:45:21 +0200 |
| |
> In this place,
I suggest to omit such a wording from the change description.
> when something goes wrong, platform_get_irq() will > print an error message,
This information is helpful here.
> so in order to avoid the situation of repeat output,
Possible adjustments: * Separate sentences
* “repeated output”
> we should remove dev_err here.
Thus remove a redundant function call.
How do you think about to change any more source files in a systematic way?
Regards, Markus
| |