Messages in this thread | | | From | Masami Hiramatsu <> | Subject | [PATCH 0/3] tracing/kprobes: Fix event generation API etc. | Date | Sat, 25 Apr 2020 14:48:59 +0900 |
| |
Hello,
Here are bugfix/cleanup patches for the kprobe tracer, [1/3] is a typo fix, [2/3] is fixing boot-time tracer and [3/3] is error checking for the new in-kernel kprobe event API.
Tom, I found that your commit 29a154810546 ("tracing: Change trace_boot to use kprobe_event interface") broke the boot-time tracer's kprobe event because of wrong API usage. Could you review it?
I marked [3/3] as a bugfix, because if the loc == NULL, __kprobe_event_gen_cmd_start() obviously does not work. But it reports actual error at kprobe_event_gen_cmd_end(). That is not good for developers to debug it.
Thank you,
---
Masami Hiramatsu (3): tracing/kprobes: Fix a double initialization typo tracing/boottime: Fix kprobe event API usage tracing/kprobes: Reject new event if loc is NULL
kernel/trace/trace_boot.c | 20 ++++++++------------ kernel/trace/trace_kprobe.c | 8 +++++++- 2 files changed, 15 insertions(+), 13 deletions(-)
-- Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
| |