lkml.org 
[lkml]   [2020]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mmc: owl-mmc: Fix dma_chan refcnt leak in owl_mmc_probe()
From
Date
> Fix this issue by jumping to "err_put_dma" label when those error
> scenarios occur.

I suggest to reconsider your jump target selection.



> +++ b/drivers/mmc/host/owl-mmc.c

> @@ -643,19 +643,22 @@ static int owl_mmc_probe(struct platform_device *pdev)
> return 0;
>
> +err_put_dma:
> + if (owl_host->dma)
> + dma_release_channel(owl_host->dma);

I interpret the source code in the way that you would like to call
this function for the desired exception handling only after a call
of the function “dma_request_chan” succeeded.
Thus I would expect that the passed pointer will usually be still valid.
(Can the proposed null pointer check be omitted then?)

How do you think about the following change possibility?

+err_release_channel:
+ dma_release_channel(owl_host->dma);


Would you like to add the tag “Fixes” to the change description?

Regards,
Markus

\
 
 \ /
  Last update: 2020-04-25 21:31    [W:0.022 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site