Messages in this thread Patch in this message | | | Date | Thu, 23 Apr 2020 07:49:43 -0000 | From | "tip-bot2 for Muchun Song" <> | Subject | [tip: objtool/core] objtool: Remove redundant .rodata section name comparison |
| |
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: 1ee444700e960b017558038a9443474e808b0045 Gitweb: https://git.kernel.org/tip/1ee444700e960b017558038a9443474e808b0045 Author: Muchun Song <songmuchun@bytedance.com> AuthorDate: Sun, 12 Apr 2020 22:44:05 +08:00 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Wed, 22 Apr 2020 10:53:50 +02:00
objtool: Remove redundant .rodata section name comparison
If the prefix of section name is not '.rodata', the following function call can never return 0.
strcmp(sec->name, C_JUMP_TABLE_SECTION)
So the name comparison is pointless, just remove it.
Signed-off-by: Muchun Song <songmuchun@bytedance.com> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> --- tools/objtool/check.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index cffa5e3..e06a891 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1354,8 +1354,8 @@ static void mark_rodata(struct objtool_file *file) * .rodata.str1.* sections are ignored; they don't contain jump tables. */ for_each_sec(file, sec) { - if ((!strncmp(sec->name, ".rodata", 7) && !strstr(sec->name, ".str1.")) || - !strcmp(sec->name, C_JUMP_TABLE_SECTION)) { + if (!strncmp(sec->name, ".rodata", 7) && + !strstr(sec->name, ".str1.")) { sec->rodata = true; found = true; }
| |