lkml.org 
[lkml]   [2020]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk()
From
Date
> kvfree ensure that the null pointer will do nothing.

I suggest to improve the commit message.
Would you like to adjust the patch subject?

Are you looking for further questionable condition checks?



> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,

> + kvfree(info);
>
> return r;
> }

How do you think about to omit a blank line behind the function call
at this source code place?

Regards,
Markus

\
 
 \ /
  Last update: 2020-04-19 10:16    [W:0.026 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site