lkml.org 
[lkml]   [2020]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] test_kmod: Avoid potential double free in trigger_config_run_type()
From
Date
> It should set config->test_fs instead of config->test_driver as NULL
> after kfree_const(config->test_fs) to avoid potential double free.

I suggest to improve this change description.

* How do you think about a wording variant like the following?

Reset the member “test_fs” of the test configuration after a call
of the function “kfree_const” to a null pointer so that a double
memory release will not be performed.

* Would you like to add the tag “Fixes”?

Regards,
Markus

\
 
 \ /
  Last update: 2020-04-18 19:25    [W:0.028 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site