Messages in this thread | | | From | Jerome Brunet <> | Subject | Re: [PATCH 2/4] clk: meson: meson8b: Fix the polarity of the RESET_N lines | Date | Fri, 17 Apr 2020 09:43:42 +0200 |
| |
On Thu 16 Apr 2020 at 20:12, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Jerome, > > On Thu, Apr 16, 2020 at 12:38 PM Jerome Brunet <jbrunet@baylibre.com> wrote: > [...] >> > >> > if (id >= ARRAY_SIZE(meson8b_clk_reset_bits)) >> > return -EINVAL; >> > >> > reset = &meson8b_clk_reset_bits[id]; >> > >> > + if (assert == reset->active_low) >> > + value = 0; >> > + else >> > + value = BIT(reset->bit_idx); >> >> if (assert ^ reset->active_low) >> value = BIT(reset->bit_idx); > I can do that, but I prefer "!=" over "^" because the result is > expected to be a bool (and because I'm not used to reading "^" for > logical comparisons) > will this work for you as well?
yes
> > > Martin
| |