Messages in this thread | | | Date | Fri, 17 Apr 2020 14:19:30 -0700 | From | "Luck, Tony" <> | Subject | Re: [PATCH 2/3] x86/split_lock: Bits in IA32_CORE_CAPABILITIES are not architectural |
| |
On Fri, Apr 17, 2020 at 11:07:37PM +0200, Thomas Gleixner wrote: > Tony, > > Thomas Gleixner <tglx@linutronix.de> writes: > > "Luck, Tony" <tony.luck@intel.com> writes: > >> Swings and roundabouts ... getting rid of the goto makes for > >> deeper indentation. But if you really want to get rid of the > >> goto, then your version is fine with me. > >> > >> Do you want me to spin it into v3? > > > > Nah. I tweak it myself. > > as I fear that the infinite wisdom of HW folks will add yet another > variant in the foreseeable future, I used a switch() right away and > tweaked the comments a bit. > > Can you have a look, please?
Looks like you are all ready for "case 2:" when Intel produces a less sucky implementation of split lock detect. Don't hold your breath waiting for that :-)
Looks good. Should be a useful template for any future bits that show up in CORE_CAPABILITIES.
-Tony
| |