Messages in this thread | | | Date | Tue, 14 Apr 2020 16:52:39 -0700 | From | Bjorn Andersson <> | Subject | Re: [RESEND][PATCH v2] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string |
| |
On Tue 14 Apr 12:06 PDT 2020, Doug Anderson wrote:
> Hi, > > On Tue, Apr 14, 2020 at 11:57 AM John Stultz <john.stultz@linaro.org> wrote: > > > > This patch fixes a regression in 5.7-rc1. > > > > In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 > > PHY support"), the change was made to add "qcom,qusb2-v2-phy" > > as a generic compat string. However the change also removed > > the "qcom,sdm845-qusb2-phy" compat string, which is documented > > in the binding and already in use. > > > > This patch re-adds the "qcom,sdm845-qusb2-phy" compat string > > which allows the driver to continue to work with existing dts > > entries such as found on the db845c. > > > > Cc: Andy Gross <agross@kernel.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Mark Rutland <mark.rutland@arm.com> > > Cc: Doug Anderson <dianders@chromium.org> > > Cc: Manu Gautam <mgautam@codeaurora.org> > > Cc: Sandeep Maheswaram <sanm@codeaurora.org> > > Cc: Matthias Kaehlcke <mka@chromium.org> > > Cc: Stephen Boyd <swboyd@chromium.org> > > Cc: Kishon Vijay Abraham I <kishon@ti.com> > > Cc: linux-arm-msm@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support") > > Reported-by: YongQin Liu <yongqin.liu@linaro.org> > > Signed-off-by: John Stultz <john.stultz@linaro.org> > > Re-adding reviews from: > https://lore.kernel.org/r/158631458374.216820.17829557619378130779@swboyd.mtv.corp.google.com > https://lore.kernel.org/r/CAD=FV=Wh9_4a-cDGPdpMrXUi_HmJvS-a2Ubeyo5WG3sgwVWKKQ@mail.gmail.com > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > ...as of an hour ago Bjorn also picked up: > > https://lore.kernel.org/r/1583747589-17267-8-git-send-email-sanm@codeaurora.org > > ...and it's now in the Qualcomm for-next and ci-next. It's still a > bit of a pain that -rc1 will have the regression since many other > maintainers will base their next branches on that, but not much to be > done about it now. >
The regression is in the driver, so we want this patch landed in v5.7. The dts change is heading for 5.8.
Regards, Bjorn
| |