Messages in this thread | | | Subject | Re: [PATCH 5/8] staging: rtl8188eu: Remove function rtw_modular64() | From | Ivan Safonov <> | Date | Sun, 12 Apr 2020 16:34:08 +0300 |
| |
> Remove function rtw_modular64 as all it does is call do_div.
This is wrong. Macro do_div(x, y) change first argument x, but rtw_modular64(x, y) preserve it.
> + tsf = pmlmeext->TSFValue - do_div(pmlmeext->TSFValue, (pmlmeinfo->bcn_interval*1024)) - 1024; /* us */
rounddown(pmlmeext->TSFValue, pmlmeinfo->bcn_interval * 1024) - 1024 is a better replacement for
> - tsf = pmlmeext->TSFValue - rtw_modular64(pmlmeext->TSFValue, (pmlmeinfo->bcn_interval*1024)) - 1024; /* us */
Patch '[PATCH 01/10] staging: rtl8723bs: Remove function rtw_modular64()' have same bug.
Ivan Safonov.
| |