Messages in this thread | | | Subject | Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough; | From | Joe Perches <> | Date | Sat, 07 Mar 2020 23:02:23 -0800 |
| |
On Sun, 2020-03-08 at 00:46 -0600, Gustavo A. R. Silva wrote: > > On 3/7/20 21:01, Joe Perches wrote: > > On Sat, 2020-03-07 at 15:30 -0600, Gustavo A. R. Silva wrote: > > > Some people consistently add blank lines as part of their code style, > > > and if I were > > > one of those people, I wouldn't like to have such lines removed. > > > > It's a patch generator, it's not perfect. > > Nothing is nor ever will be. > > Wise words. The thing is that this is feedback over a proposed > patch. > > > It's quite simple to add blank lines if that's > > what any maintainer desires. > > > > I'm not sure if you are saying that it's not a problem to > update your proposed patch,
It's not a problem with my proposed patch. Consistency is good.
Nearly all uses in mm do not have blank lines after break.
> or if you are suggesting that > the maintainers will have the predisposition of applying > patches that will modify their coding style and then go and > willingly fix that. I doubt the latter, though.
If any do actually use the script, I guess we'll see.
> -- > Gustavo
| |