Messages in this thread | | | From | "Gustavo A. R. Silva" <> | Subject | Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough; | Date | Sun, 8 Mar 2020 00:46:23 -0600 |
| |
On 3/7/20 21:01, Joe Perches wrote: > On Sat, 2020-03-07 at 15:30 -0600, Gustavo A. R. Silva wrote: >> Some people consistently add blank lines as part of their code style, >> and if I were >> one of those people, I wouldn't like to have such lines removed. > > It's a patch generator, it's not perfect. > Nothing is nor ever will be.
Wise words. The thing is that this is feedback over a proposed patch.
> It's quite simple to add blank lines if that's > what any maintainer desires. >
I'm not sure if you are saying that it's not a problem to update your proposed patch, or if you are suggesting that the maintainers will have the predisposition of applying patches that will modify their coding style and then go and willingly fix that. I doubt the latter, though.
-- Gustavo
| |