Messages in this thread Patch in this message | | | Date | Sat, 7 Mar 2020 09:08:08 +0300 | From | Dan Carpenter <> | Subject | [PATCH] bfs: prevent underflow in bfs_find_entry() |
| |
We check if "namelen" is larger than BFS_NAMELEN but we don't check if it's less than zero so it causes a static checker.
fs/bfs/dir.c:346 bfs_find_entry() warn: no lower bound on 'namelen'
It's nicer to make it unsigned anyway.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- fs/bfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index d8dfe3a0cb39..46a2663e5eb2 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -326,7 +326,7 @@ static struct buffer_head *bfs_find_entry(struct inode *dir, struct buffer_head *bh = NULL; struct bfs_dirent *de; const unsigned char *name = child->name; - int namelen = child->len; + unsigned int namelen = child->len; *res_dir = NULL; if (namelen > BFS_NAMELEN) -- 2.11.0
| |