Messages in this thread Patch in this message | | | Date | Mon, 30 Mar 2020 18:27:02 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write |
| |
In case memory resources for dummy_data were allocated, release them before return.
Addresses-Coverity-ID: 1491997 ("Resource leak") Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/net/netdevsim/dev.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c index 2b727a7001f6..9897e9a0e26f 100644 --- a/drivers/net/netdevsim/dev.c +++ b/drivers/net/netdevsim/dev.c @@ -75,6 +75,7 @@ static ssize_t nsim_dev_take_snapshot_write(struct file *file, err = devlink_region_snapshot_id_get(devlink, &id); if (err) { pr_err("Failed to get snapshot id\n"); + kfree(dummy_data); return err; } err = devlink_region_snapshot_create(nsim_dev->dummy_region, -- 2.23.0
| |