| Date | Fri, 27 Mar 2020 12:37:38 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH v4 4/8] usb: mausb_host: Implement initial hub handlers |
| |
On Fri, 27 Mar 2020 vladimir.stankovic@displaylink.com wrote:
> Implemented handlers for subset of HCD events. > > Signed-off-by: Vladimir Stankovic <vladimir.stankovic@displaylink.com> > --- > +/* > + * For usb 2.0 logitech camera called multiple times, once during > + * enumeration of device and later after mausb_reset_device. > + */ > +static int mausb_address_device(struct usb_hcd *hcd, struct usb_device *dev)
> +/* > + * For usb 2.0 logitech camera called multiple times, once during enumeration > + * of device and later after mausb_reset_device. In latter case it is > + * required to address the device again in order for ep0 to work properly. > + */ > +static int mausb_enable_device(struct usb_hcd *hcd, struct usb_device *dev)
> +/* > + * For usb 2.0 logitech camera called multiple times, > + * followed by either mausb_enable_device or mausb_address_device. > + * Resets device to non-addressed state. > + */ > +static int mausb_reset_device(struct usb_hcd *hcd, struct usb_device *dev)
Why on earth do you have all these comments about Logitech cameras? A host controller driver shouldn't care about the type of devices it gets connected to.
Alan Stern
|