lkml.org 
[lkml]   [2020]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 5/8] usb: mausb_host: Introduce PAL processing
On Sat, 25 Apr 2020 vladimir.stankovic@displaylink.com wrote:

> Protocol adaptation layer (PAL) implementation has been added to
> introduce MA-USB structures and logic.
>
> Signed-off-by: Vladimir Stankovic <vladimir.stankovic@displaylink.com>

...

> + /*
> + * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it
> + * should not, so it is breaking the USB drive on the linux
> + */
> + urb->transfer_flags &= ~URB_SHORT_NOT_OK;

Removing the SHORT_NOT_OK flag is _not_ a valid thing to do. It will
cause drivers to malfunction.

Can you please explain this comment?

What SCSI driver?

When is the flag being added?

How does it break USB drives?

Why haven't you already reported this problem to the
appropriate maintainers?

Alan Stern

\
 
 \ /
  Last update: 2020-04-26 02:33    [W:0.144 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site